@laeubi my "first Tycho based clean-up". Can you do a quick sanity check?

In general it looks fine, if you want to test it do:

• In folder eclipse-platform-parent perform mvn clean install
• No go into a project where you know the cleanup should be applicable
• Then run mvn -B -ntp -e tycho-cleancode:quickfix@quickfixes
• Check if the desired cleanup was performed properly

Thanks @laeubi will do. Just for my understanding, once this is committed all our repos will start generating PR for this clean-up? Do we have a list of the repos in which the clean-ups are active? I don't think they autoactivate for all our repos, or do they?

Currently activate repos are

• PDE
• P2
• Equinox

planned for next release

• platform
• (maybe platform.ui depends on how many people actually help in review / merging stuff)

mvn -B -ntp -DskipTests=true -e tycho-cleancode:quickfix@quickfixes works fine locally. I only had to add -PbuildIndividualBundles to the command.

Planning to merge it early next week unless someone speaks up.

Planning to merge it early next week unless someone speaks up.

Please make sure to review (and probably merge) cleanup PRs as well as reporting any issues to jdt(ui).

Planning to merge it early next week unless someone speaks up.

I think the topic from my remark from eclipse-platform/eclipse.platform#1868 (comment) respectively the following, should be decided before this particular change is submitted.

Planning to merge it early next week unless someone speaks up.

I think the topic from my remark from eclipse-platform/eclipse.platform#1868 (comment) respectively the following, should be decided before this particular change is submitted.

See eclipse-platform/eclipse.platform#1868 (comment)

Thanks for all the responses in eclipse-platform/eclipse.platform#1868. With the gathered information it's in my opinion fine to enable that clean-up.

So we are good to go for this additional clean-up. Whoever feels like he has time to look at the auto-generated PRs can merge. I might also do it in the near future.

Looks like @fedejeanne does not like unnecessary ws :-)

Looks like @fedejeanne does not like unnecessary ws :-)

Not one bit 😅